fix: Handle data: URIs more consistently #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
force-pushed
the
isaacs/handle-data-urls-properly
branch
2 times, most recently
from
229649c
to
561782a
Compare
isaacs
force-pushed
the
isaacs/handle-data-urls-properly
branch
from
3cd69ff
to
5255b79
Compare
wraithgar
force-pushed
the
isaacs/handle-data-urls-properly
branch
from
5255b79
to
a8526e1
Compare
1. No longer requires `;base64` to be included on `data:` URIs. 2. Supports immediately aborting `data:` URIs. Fix: #18
wraithgar
force-pushed
the
isaacs/handle-data-urls-properly
branch
from
a8526e1
to
fb2237f
Compare
nlf
reviewed
Mar 1, 2022
Comment on lines
+18
to
+19
| // XXX this should really be split up and unit-ized for easier testing | ||
| // and better DRY implementation of data/http request aborting |
nlf
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
;base64to be included ondata:URIs.data:URIs.Fix: #18
References