fix: check for existence of unref before calling #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. Needs a test that fails without the patch and passes with it, though. |
|
I've added a test that overrides setTimeout to emulate running in environments that don't have unref. I'm not super familiar with tap so I'm not sure how to ensure that setTimeout gets reset if the test throws. Please let me know if you think there's a better way to have the test mock that behaviour |
Environments like Electron do not always expose the Node.js setTiemout, so there is no unref function on resTimeout. So update the check to also check if the unref function exists Ref: electron/electron#21162 PR-URL: npm#13 Credit: @ewanharris Close: npm#13 Reviewed-by: @isaacs
isaacs
force-pushed
the
check_unref_existence
branch
from
af101bb
to
05fb45b
Compare
|
Thanks! I tweaked the test a little to put the reset into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environments like Electron do not always expose the Node.js setTiemout, so there is no unref
function on resTimeout. So update the check to also check if the unref function exists
Ref: electron/electron#21162