From 404ad4cf1a2c21563205bee21ca1ef785b31c72f Mon Sep 17 00:00:00 2001 From: nlf Date: Wed, 2 Mar 2022 10:36:05 -0800 Subject: [PATCH] fix: pass search params as part of path string (#40) --- lib/request.js | 2 +- test/request.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/request.js b/lib/request.js index 4702f65..e620df6 100644 --- a/lib/request.js +++ b/lib/request.js @@ -238,7 +238,7 @@ class Request extends Body { : '', host: parsedURL.host, hostname: parsedURL.hostname, - path: parsedURL.pathname, + path: `${parsedURL.pathname}${parsedURL.search}`, port: parsedURL.port, protocol: parsedURL.protocol, } diff --git a/test/request.js b/test/request.js index 371dcdb..5e8cb9c 100644 --- a/test/request.js +++ b/test/request.js @@ -398,6 +398,15 @@ t.test('get node request options', t => { family: 6, }) + t.test('passes through search params', (t) => { + const req = new Request('http://x.y?one=two&three=four') + const options = Request.getNodeRequestOptions(req) + t.match(options, { + path: '/?one=two&three=four', + }) + t.end() + }) + t.test('function as agent', t => { let agentCalled = false const agent = () => {