Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests #79

Merged
merged 3 commits into from
Mar 9, 2021
Merged

refactor tests #79

merged 3 commits into from
Mar 9, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Mar 2, 2021

this is an effort to refactor the testing baseline to something easier to navigate and extend.

yes, it's very verbose, but it makes it extremely clear what inputs are parseable and what are not and adding new test cases is as simple as it can be.

@nlf nlf marked this pull request as ready for review March 3, 2021 15:57
@nlf nlf marked this pull request as draft March 3, 2021 17:37
@nlf
Copy link
Contributor Author

nlf commented Mar 3, 2021

converted back to draft because t.match() was not doing what i thought it was so many of these tests are passing but not actually passing. will fix the assertions, fix the tests to match and update this pull request

@nlf nlf marked this pull request as ready for review March 3, 2021 20:29
@nlf nlf mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants