Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pathmatch for GitLab treats tarball archives as git repos #50

Closed
isaacs opened this issue Sep 24, 2019 · 2 comments
Closed

Pathmatch for GitLab treats tarball archives as git repos #50

isaacs opened this issue Sep 24, 2019 · 2 comments
Assignees
@mikemimik
Projects
Release - v6.12.0

Comments

@isaacs
Copy link
Contributor

isaacs commented Sep 24, 2019

Better path match (discovered during pair debugging: /^[/]([^/]+)[/](?!.*\/-\/)(.+?)(?:[.]git|[/])?$/)
@isaacs isaacs added this to To do in Release - v6.12.0 via automation Sep 24, 2019
@mikemimik
Copy link

mikemimik commented Sep 24, 2019 •
edited

Issue From Community:

Task:

  • Checkout v2.8.4; apply fix; publish v2.8.5
  • Cherry pick fix into v3.0.0 then publish v3.0.1

@mikemimik mikemimik added the bug label Sep 24, 2019
@mikemimik mikemimik moved this from To do to In progress in Release - v6.12.0 Sep 25, 2019
This was referenced Sep 28, 2019
Closed
Closed
@isaacs
Copy link
Contributor Author

isaacs commented Oct 8, 2019

Fixed by #51 and #52

@isaacs isaacs closed this as completed Oct 8, 2019
Release - v6.12.0 automation moved this from In progress to Done Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemimik mikemimik

Labels
None yet
Projects
No open projects
Release - v6.12.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/50 fix gitlab pathmatch 3 0 0 npm/hosted-git-info
2 participants
@isaacs @mikemimik