Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Move props.path check below class init #55

Merged
merged 1 commit into from Mar 7, 2017
Merged

Move props.path check below class init #55

merged 1 commit into from Mar 7, 2017

Conversation

ZJONSSON
Copy link
Contributor

self.error is not available until the prototype is available

Before:

fstream.Writer({})
// TypeError: self.error is not a function

After:

fstream.Writer({})
// Error: Must provide a path

@ZJONSSON
Move props.path check below class init
23199af 
`self.error` is not available until the prototype is available
@zkat zkat removed the review label Mar 7, 2017
@zkat zkat merged commit ac4a9e3 into npm:master Mar 7, 2017
@ZJONSSON
Copy link
Contributor Author

ZJONSSON commented Mar 7, 2017

Wohoo!! Thanks!

@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZJONSSON @zkat @othiym23