fix: add global getter to npm class #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
commented
May 24, 2022
| @@ -343,7 +343,9 @@ t.test('should return if no outdated deps', async t => { | |||
| }) | |||
|
|
|||
| await outdated(testDir, { | |||
| global: false, | |||
| config: { | |||
There was a problem hiding this comment.
these tests were passing entirely by coincidence. if they had been setting global to true they would not have done the expected thing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently everywhere we were doing
this.npm.config.get('global')was not accounting for thelocationflag, so keeping in tradition with our other "derived" configs iattached it as a getter to the npm class and changed all the references to use the getter