Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not alter file ownership #141

Merged
merged 1 commit into from Oct 13, 2022
Merged

feat: do not alter file ownership #141

merged 1 commit into from Oct 13, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Oct 12, 2022

BREAKING CHANGE: this module no longer attempts to change file ownership automatically

@nlf nlf requested a review from a team as a code owner October 12, 2022 16:52
wraithgar
wraithgar reviewed Oct 12, 2022
View reviewed changes
lib/rm.js Show resolved Hide resolved
wraithgar
wraithgar approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved w/ some double checking questions and assuming the answers to them are good.

@nlf
Copy link
Contributor Author

nlf commented Oct 12, 2022 •
edited

i'm going to hold off on landing this until i publish a new major of @npmcli/fs and update it here so we can get all the breaking changes lumped together this is done

@nlf
feat: do not alter file ownership
d30f284 
BREAKING CHANGE: this module no longer attempts to change file ownership automatically
@nlf nlf force-pushed the nlf/remove-ownership-changes branch from 437d1bc to d30f284 Compare October 12, 2022 18:06
@nlf nlf mentioned this pull request Oct 13, 2022
Closed
@nlf nlf merged commit 479b135 into main Oct 13, 2022
@nlf nlf deleted the nlf/remove-ownership-changes branch October 13, 2022 18:29
@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
@Omrisnyk Omrisnyk mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlf @wraithgar