Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalCrashHandler does not pass exception to Layout #98

Open
jonathantwite opened this issue Jan 23, 2017 · 0 comments
Open

GlobalCrashHandler does not pass exception to Layout #98

jonathantwite opened this issue Jan 23, 2017 · 0 comments

Comments

@jonathantwite
Copy link

GlobalCrashHandler incorrectly (I believe) sends the UnhandledExceptionEventArgs rather than the Exception to log.FatalAsync(...). This means that any custom layouts do not show the exception and you get different outputs depending on whether the log came from a log.Fatal() call, or an unhandled exception caught by GlobalCrashHandler.

await log.FatalAsync("The application crashed: " + e.Message, e);
should be:
await log.FatalAsync("The application crashed: " + e.Message, e.Exception);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant