Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add validation for more macOS and netcore versions #220

Merged
merged 1 commit into from Apr 2, 2020

Conversation

jeromelaban
Copy link
Contributor

This PR adds an extended validation matrix to ensure msbuild extras work with a wider range of .NET Core and macOS versions.

@jeromelaban jeromelaban force-pushed the dev/jela/builds branch 3 times, most recently from 660f890 to ae69d8b Compare April 2, 2020 01:21
@jeromelaban
Copy link
Contributor Author

And it looks like there's an issue with netcore 3.1 on linux specifically (most likely to happen on macOS as well if .NET Core 3.1 gets the default): https://dev.azure.com/clairernovotny/GitBuilds/_build/results?buildId=3438&view=logs&j=a3deec3d-20d7-5d79-2090-7e19368c4709&t=cfff7be9-a121-5ebd-a90b-8bb7e69a46ab

@clairernovotny Do you know about this file ?

@clairernovotny
Copy link
Collaborator

No idea, can you file an issue on the main dotnet repos?

@jeromelaban
Copy link
Contributor Author

Will do. I'll remove 3.1 from the matrix and create a new PR with just that to enable it.

@jeromelaban
Copy link
Contributor Author

There it is https://github.com/dotnet/runtime/issues/34435

@clairernovotny clairernovotny merged commit 5b219fc into novotnyllc:master Apr 2, 2020
@clairernovotny
Copy link
Collaborator

Thanks!

@jeromelaban jeromelaban deleted the dev/jela/builds branch April 2, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants