Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the XAJavaInterop1 codegen by default #189

Merged
merged 1 commit into from Oct 7, 2019

Conversation

Redth
Copy link
Contributor

@Redth Redth commented Oct 7, 2019

See: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/building-apps/build-process#binding-project-build-properties

Basically, smaller, faster bindings - this does require 6.1 or later, so there's a condition for that.

This also bumps TargetFrameworkVersion to something a bit more sane (really I'd like to see this go to 9.0)

See: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/building-apps/build-process#binding-project-build-properties

Basically, smaller, faster bindings - this does require 6.1 or later, so there's a condition for that.

This also bumps TargetFrameworkVersion to something a bit more sane (really I'd like to see this go to 9.0)
@clairernovotny
Copy link
Collaborator

Thanks!

For the min version, keep in mind that only applies if someone specifies MonoAndroid. If they put in a version, like MonoAndroid80 or MonoAndroid9, that'll always win.

@clairernovotny clairernovotny merged commit adce315 into novotnyllc:master Oct 7, 2019
@Redth
Copy link
Contributor Author

Redth commented Oct 7, 2019

Yup, true, just like pushing our users to newer versions of android to target, especially now that Google is enforcing this more strictly in the play store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants