Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Option to disable DolbyVision #800

Closed
coolllman opened this issue Jan 10, 2023 · 11 comments
Closed

[FEAT]: Option to disable DolbyVision #800

coolllman opened this issue Jan 10, 2023 · 11 comments
Assignees
Labels
enhancement New feature or request Important Bug severity

Comments

@coolllman
Copy link

coolllman commented Jan 10, 2023

Description

I have sheld tv pro 2019 and its support dolby vision, but my tv support only hdr10, and when i play hdr+dolby mix mkv, hdr don't work, nova player the best, and only this problem don't make me quit from vimu player (in this player, this option work great), thank you

P.s. sorry for my bad english
Update: test all mkv with hdr+dolby in kodi, hdr works good, but nova player better, any chance to fix it?

Additional information

No response

@coolllman coolllman added the enhancement New feature or request label Jan 10, 2023
@courville courville self-assigned this Jan 10, 2023
@courville courville added the Important Bug severity label Jan 10, 2023
@courville
Copy link
Contributor

courville commented Jan 10, 2023

Looking at google/ExoPlayer#9794, it seems that nova could have an option to disable dolby vision codec by rejecting them in CodecDiscovery so that isCodecTypeSupported would report in avos stream_parser_ffmpeg:_parse_format that it needs to switch to another codec.

Could be useful for TVs not supporting DOVI. Perhaps DOVI could be disabled too at platform level in global Android settings on some platforms.

@coolllman
Copy link
Author

Wow, its great))

@courville
Copy link
Contributor

@coolllman, I just plugged by shield 2019 (not pro) and in order to get DOVI you need to specifically request this display mode in the shield Android "Settings > Device Preferences > Display & Sound > Advanced display settings > Custom display mode and select any mode labelled “Dolby Vision Ready”."
When not selecting a DoVi display mode, my TV stays with normal colors without DoVi triggered.

Now this is for bluray dolby vision content (typically movies) but for tv shows I get funky green/purple colors and exoplayer trick will not help here.

Can you please provide the full video file name (including codec/resolution/DV etc.) on which it does not work in nova and it works with vimu player?

@coolllman
Copy link
Author

coolllman commented Jan 13, 2023

Its about 20 mkvs, all dolby vision + hdr10 mix mkv, when tv don't have dovi, its goes to hdr10, in kodi and vimu when plays this mkv, my lg tv switch to hdr, in nova play, tv not switch to hdr and stays in sdr. In vimu if i enable dolby vision option, tv don't switch tv to hdr the same as nova, disable dolby vision setting in vimu and tv switch to hdr10.
Sample:
https://disk.yandex.kz/i/8x7WPHUjXMmclA

courville added a commit to nova-video-player/aos-Video that referenced this issue Jan 14, 2023
it does not work yet since native avos goes in exception trying to call CodecDiscovery (to be fixed)

See nova-video-player/aos-AVP#800
@courville
Copy link
Contributor

TODO: fix avos throwing an exception while calling CodecDiscovery in avos:android_codec:acodecs_is_type_supported.

@courville
Copy link
Contributor

@coolllman thanks for sharing the samples, once the code is complete, I will give it a try.
Sample shared is DoVi two layers (el = extended layer in ffprobe) thus there is hope.
Method proposed will not work with single layer DoVi files.

@coolllman
Copy link
Author

Courville big thank you for your hard work and awesome media player!

courville added a commit to nova-video-player/aos-avos that referenced this issue Jan 17, 2023
courville added a commit to nova-video-player/aos-Video that referenced this issue Jan 17, 2023
@courville
Copy link
Contributor

OK tested to work on the shield. Will be there in next release.

@coolllman
Copy link
Author

Thank you, will wait next release.

@courville
Copy link
Contributor

Pre-release to test available here https://github.com/nova-video-player/aos-AVP/releases/tag/v6.0.94

@coolllman
Copy link
Author

Thank you very much, all work great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Important Bug severity
Projects
None yet
Development

No branches or pull requests

2 participants