add accessor for whether rescan is required on Event #435
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
bgw
added a commit
to vercel/next.js
that referenced
this pull request
Apr 18, 2025
The notify crate requires handling rescan events with the event queue overflows. Context on this issue in the notify crate: - notify-rs/notify#412 - notify-rs/notify#434 - notify-rs/notify#435 In our case, that means we should invalidate every file we've read in `turbo-tasks-fs`. We should also attempt to re-add filesystem watchers for every path, since some of those paths could've been removed and re-added. Tested this on Linux by lowering the inotify queue to something tiny to trigger frequent rescan events: ``` echo 3 | sudo tee /proc/sys/fs/inotify/max_queued_events rm -rf /tmp/fuzz && RUST_BACKTRACE=1 cargo run -p turbo-tasks-fuzz -- fs-watcher --fs-root /tmp/fuzz --notify-timeout-ms 100 --directory-modifications 0 echo 16384 | sudo tee /proc/sys/fs/inotify/max_queued_events # restore back to default ``` As a sanity check, I also tried running the fuzzer on macos, though it doesn't seem like there's as easy of a way to trigger rescan events on that platform (?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a low-effort/no-breakage solution to #434