Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify 5.0.0-pre.14 doesn't build with kqueue 1.0.5 #401

Closed
lnicola opened this issue Apr 28, 2022 · 7 comments
Closed

notify 5.0.0-pre.14 doesn't build with kqueue 1.0.5 #401

lnicola opened this issue Apr 28, 2022 · 7 comments

Comments

@lnicola
Copy link

lnicola commented Apr 28, 2022

kqueue 1.0.5 contains a breaking change (it added some variants to a public enum), so notify no longer builds on some platforms when using that version. This is a kqueue bug, but I'm filing this here to track the problem.

Spotted in rust-lang/rust#96476 (comment).

@0xpr03
Copy link
Member

0xpr03 commented Apr 28, 2022

Would be nice if kqueue would mark their enum non-exhaustive.

What do you intend notify to do for now ?

@lnicola
Copy link
Author

lnicola commented Apr 28, 2022

You could pin the kqueue dependency (either to 1.0.4 or to 1.0.5 like in 602db9f), or you could just ignore the problem. I only opened this so it's known.

@worr
Copy link

worr commented Apr 28, 2022

Sorry for the break, I've released 1.0.6 of kqueue to resolve it.

@0xpr03
Copy link
Member

0xpr03 commented Apr 28, 2022

Then I'll close this. Thanks for fixing it so fast.

@0xpr03 0xpr03 closed this as completed Apr 28, 2022
@lnicola
Copy link
Author

lnicola commented Apr 28, 2022

@0xpr03 might be a good idea to add a fallback arm to that match? I can't check the code, but it might not compile otherwise.

@0xpr03
Copy link
Member

0xpr03 commented Apr 28, 2022

Ah yeah, will do.

@0xpr03 0xpr03 reopened this Apr 28, 2022
@0xpr03
Copy link
Member

0xpr03 commented Apr 30, 2022

This is actually already fixed by #399 and I missed that fact until I just looked into the main source..

@0xpr03 0xpr03 closed this as completed Apr 30, 2022
bors added a commit to rust-lang/rust-analyzer that referenced this issue Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants