Clarify violation messages for no-missing-placeholders and no-unused-placeholders
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Aug 4, 2022
bmish
added a commit
to bmish/eslint-plugin-eslint-plugin
that referenced
this pull request
Aug 4, 2022
* main: fix: clarify report messages for no-missing-placeholders and no-unused-placeholders (eslint-community#278) fix: allow additional schema types in require-meta-schema (eslint-community#277)
bmish
added a commit
to bmish/eslint-plugin-eslint-plugin
that referenced
this pull request
Aug 4, 2022
* main: fix: reporting location in no-missing-placeholders (eslint-community#280) fix: clarify report messages for no-missing-placeholders and no-unused-placeholders (eslint-community#278) fix: allow additional schema types in require-meta-schema (eslint-community#277)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #276, I noticed that the existing violation messages were particularly confusing. The messages "the placeholder is missing" or "the placeholder does not exist" are very ambiguous about what they mean.