Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config example in README #245

Merged
merged 1 commit into from Apr 2, 2022

Conversation

bmish
Copy link
Member

@bmish bmish commented Mar 28, 2022

  • Provides single unified code sample in "Usage" section
  • No more need to specify plugins since our configs already do that for the user
  • Suggests using the recommended config in the "Usage" section instead of just manually enabling a recommended rule
  • Demonstrates enabling an optional rule
  • Explains when sourceType should be set to script vs. module

Fixes #244.

@tristanHessell
Copy link

@bmish This is the kind of thing I had in mind - much appreciated!

@aladdin-add aladdin-add merged commit 9456ed1 into eslint-community:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin requires "parserOptions.sourceType" being configured to "script"
3 participants