Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict mode for well-formed names in NB identifiers #1808

Open
jshook opened this issue Feb 6, 2024 · 0 comments
Open

Add strict mode for well-formed names in NB identifiers #1808

jshook opened this issue Feb 6, 2024 · 0 comments

Comments

@jshook
Copy link
Contributor

jshook commented Feb 6, 2024

At some point in the near future, names which can cause issue with downstream metrics systems should be
avoided completely. This means that any name which includes dashes, or otherwise does not conform to a valid open metrics label name or value should cause an error.

As the first step, places where users can provide these labels should be enabled with advisory warnings indicating that the format will be deprecated, suggesting an alternate example form.

This includes these places at least:

  • workload parameters
  • template variables
  • label names and values
  • tag names and values
  • op field properties which may be included in metrics or logging
  • activity names, container names, container variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant