Upgrade GitHub Actions #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Jul 15, 2022
|
I will note briefly that I don't like having additional little changes slipped in which aren't mentioned in the PR message or commit messages. It makes it harder to know what's intentional, or to have a good conversation about the changes. In this case, I'm referring to the updates to use That said, those changes are good anyway! Big thanks for the changes and to @hugovk for stepping in to do review and feedback! 👍 I'm also going to follow-up on this by setting up dependabot to do automatic PRs to update github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test fixed in #529