Discover and fix typos with codespell #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
force-pushed
the
patch-3
branch
2 times, most recently
from
69b81ae
to
94715a3
Compare
Closed
sirosen
requested changes
Jul 16, 2022
There was a problem hiding this comment.
I've never used codespell before but I'm interested in it already. It looks like it has the necessary level of configurability (mostly, ignore rules) to be safely usable. Thanks for bringing this up and proactively applying the changes!
However, there are some changes which are needed before this can merge. Primarily, I think it needs to be rebased to pick up the latest GitHub Actions config, and I've left some inline comments on a few things of note.
cclauss
changed the title
|
This looks good now, thanks! If it ever becomes an issue for any reason, the linting can always be removed. And it fixes some very old typos, so that's great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codespell -wto fix all typos. -- https://pypi.org/project/codespell