Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content delivery system Integration for landing #156

Closed
bindlr opened this issue Jun 13, 2019 · 2 comments
Closed

Content delivery system Integration for landing #156

bindlr opened this issue Jun 13, 2019 · 2 comments

Comments

@bindlr
Copy link

bindlr commented Jun 13, 2019

Related issues:
#129 #144

Description

This issue is to discover whether there's a need to integrate MDX for landing pages. If this is indeed in the roadmap, we can allocate resource to it as we are at a position where we have to decide whether Landing Pages remains as is or it's safer to switch to MDX.

One possible reason for keeping things the way they are currently, might be the way the Landing Page have been setup. I understand the efficiency and ease of use of existing setup. However, components and UI elements that are used are almost exclusively used for Nord project and they might not provide proper brand identity for other project. Therefore a suggestion can be to either

a. Integration with CMS system to serve dynamic content as seen in Blog and Docs pages.
b. Define a mechanism that assets in the project can be easily replaced. Ideally better api for animations. etc..

@ghost
Copy link

ghost commented Jun 14, 2019

I was able to take a better look at this case. I believe the following approach could work. ( Appreciate feedback from authors)

Instead of integrating MDX for the landing page, which now I believe is over engineering things, we can use Netlify CMS to distribute the landing page content and assets.

This approach could also work with how landing page setup has been laid out and provides a user friendly interface to swap and customize asset.

I also noticed that Netlify is already supporting CI/CD pipeline and that's another reason for my conclusion.

To have matter in motion, I went ahead and implemented above scenario and can confirm feasibility of this approach.

There is one unclear part and that's the current custom layout of the landing page and how we can convert it to a Netlify CMS collection. Is it going to be a single collection with multiple fields that eventually form a unified page or shall I consider each section as a page and find a way to “stick it” together at some point. File collection type seems to be the way to go

@bindlr bindlr changed the title MDX Integration for landing Content delivery Integration for landing Jun 15, 2019
@bindlr bindlr changed the title Content delivery Integration for landing Content delivery system Integration for landing Jun 15, 2019
@bindlr bindlr closed this as completed Jun 16, 2019
@bindlr
Copy link
Author

bindlr commented Jun 16, 2019

For anyone arriving here with the same question, I solved this issue by issuing styled-jsx It also helped with templating but since this is not at all inline with upstream, I won't send request a pull for it. I will share the link here soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant