Add hardhat_metadata RPC method #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 34f6c34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fvictorio
commented
Nov 29, 2022
packages/hardhat-core/src/internal/hardhat-network/provider/modules/web3.ts
Show resolved
Hide resolved
packages/hardhat-core/src/internal/hardhat-network/provider/utils/makeForkClient.ts
Show resolved
Hide resolved
alcuadrado
reviewed
Nov 29, 2022
| // This field is only present when Hardhat Network is forking another chain. | ||
| forkedNetwork?: { | ||
| // The chainId of the network that is being forked | ||
| chainId: number; |
There was a problem hiding this comment.
Should add networkId here, for consistency?
There was a problem hiding this comment.
Removed networkId instead.
alcuadrado
approved these changes
Nov 29, 2022
We decided to drop |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
hardhat_metadataRPC method. This method is meant to be used by other tools, like wallets or deployment systems, to get information about the instance of the network.