Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process transactions with unknown tx types #3302

Merged
merged 3 commits into from Oct 27, 2022

Conversation

fvictorio
Copy link
Member

@fvictorio fvictorio commented Oct 26, 2022

Closes #2995.
Closes #3194.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

🦋 Changeset detected

Latest commit: 53ff90c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 3:15PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 3:15PM (UTC)

@linear
Copy link

linear bot commented Oct 26, 2022

HH-998 Add flag to ignore unknown EIP-2718 types when forking [NomicFoundation/hardhat#2995]

Certain EVM blockchain (e.g. Arbitrum Nitro) have non-standard EIP-2718 typed transaction that would prevent hardhat fork from working due to Unknown transaction type

While it is rarely a good idea to use hardhat fork with these blockchain due to chain specific behavior and precompiles as discussed in #1902, some devs found it helpful to test non-chain specific logic with a hardhat fork. To workaround the Unknown transaction type error, I am proposing to add an optional --fork-ignore-unknown-tx-type flag to skip those transactions.

You can reproduce the error with

hardhat node --fork https://goerli-rollup.arbitrum.io/rpc
	ArbitrumDepositTxType         = 100
	ArbitrumUnsignedTxType        = 101
	ArbitrumContractTxType        = 102
	ArbitrumRetryTxType           = 104
	ArbitrumSubmitRetryableTxType = 105
	ArbitrumInternalTxType        = 106
	ArbitrumLegacyTxType          = 120

Here is a draft impl: gzeoneth@c7918d5


Github issue/pull request

This issue was automatically created, do not edit its description.

GH-ID: #2995

@fvictorio fvictorio merged commit 8575354 into main Oct 27, 2022
@fvictorio fvictorio deleted the add-flag-to-ignore-unknown-eip-2718-hh-998 branch October 27, 2022 15:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants