-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix two solidity-analyzer
-related errors
#3189
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3f38020 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This issue is also being tracked on Linear. We use Linear to manage our development process, but we keep the conversations on Github. LINEAR-ID: c3206a1d-5d52-4819-817f-09d93a94deb3 |
title: "Corrupted lockfile", | ||
description: `Some versions of NPM are affected [by a bug](https://github.com/npm/cli/issues/4828) that leads to corrupt lockfiles being generated. | ||
|
||
This bug can only affect you if you are installing your project without a lockfile, but with an existing node_modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something here, but I think this is misleading, because this is what the person that generated the corrupted lockfile did, not what the person finding the bug did.
So I guess the message should be something like: "This bug can happen if one of your teammates generated the lockfile using a different operating system or architecture."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great point!
This small PR fixes two errors related to
solidity-analyzer
:0.1.0
. As we were using^
and0.0.x
, Hardhat wasn't getting any dependency update.Fixes #3176