Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two solidity-analyzer-related errors #3189

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Conversation

alcuadrado
Copy link
Member

@alcuadrado alcuadrado commented Sep 16, 2022

This small PR fixes two errors related to solidity-analyzer:

  1. It bumps it to 0.1.0. As we were using ^ and 0.0.x, Hardhat wasn't getting any dependency update.
  2. It detects NPM's issue Error HH415 when running hardhat compile #4828 and prints a clear error message explaining how to fix it.

Fixes #3176

@vercel
Copy link

vercel bot commented Sep 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hardhat ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 5:30PM (UTC)
hardhat-storybook ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 5:30PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: 3f38020

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: c3206a1d-5d52-4819-817f-09d93a94deb3

title: "Corrupted lockfile",
description: `Some versions of NPM are affected [by a bug](https://github.com/npm/cli/issues/4828) that leads to corrupt lockfiles being generated.

This bug can only affect you if you are installing your project without a lockfile, but with an existing node_modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something here, but I think this is misleading, because this is what the person that generated the corrupted lockfile did, not what the person finding the bug did.

So I guess the message should be something like: "This bug can happen if one of your teammates generated the lockfile using a different operating system or architecture."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great point!

@fvictorio fvictorio merged commit e4d1162 into main Oct 10, 2022
@fvictorio fvictorio deleted the solidity-analyzer-errors branch October 10, 2022 14:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.11.1-MODULE_NOT_FOUND
2 participants