Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block.chainid returning 0 in view functions #2766

Merged
merged 2 commits into from May 30, 2022

Conversation

fvictorio
Copy link
Member

No description provided.

@fvictorio fvictorio requested a review from feuGeneA May 27, 2022 16:48
@linear
Copy link

linear bot commented May 27, 2022

@vercel
Copy link

vercel bot commented May 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nomic-foundation-hardhat ❌ Failed (Inspect) May 27, 2022 at 4:53PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented May 27, 2022

🦋 Changeset detected

Latest commit: 73beb27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@feuGeneA feuGeneA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: why use pre-compiled bytecode and ABI instead of compiling just in time?

@fvictorio
Copy link
Member Author

Just out of curiosity: why use pre-compiled bytecode and ABI instead of compiling just in time?

Because I forgot we could do that now 🙄

@fvictorio fvictorio merged commit bc1db44 into master May 30, 2022
@fvictorio fvictorio deleted the francovictorio/hh-688/chainid-zero-view-functions branch May 30, 2022 14:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants