Typescript errors in 2.0.4 eg Not all code paths return a value

[payprmoney]

When I bump from version 2.0.3 to 2.0.4, I get new typescript compilation errors I didn't see before:

node_modules/hardhat/src/internal/hardhat-network/stack-traces/model.ts:278:55 - error TS7030: Not all code paths return a value.

278   public static fromABI(name: string, inputs: any[]): CustomError | undefined {
                                                          ~~~~~~~~~~~~~~~~~~~~~~~

node_modules/hardhat/src/types/config.ts:273:11 - error TS2503: Cannot find namespace 'Mocha'.

273   mocha?: Mocha.MochaOptions;
              ~~~~~

node_modules/hardhat/src/types/config.ts:281:10 - error TS2503: Cannot find namespace 'Mocha'.

281   mocha: Mocha.MochaOptions;
             ~~~~~


Found 3 errors.

I have confirmed that everything works great when moving back to 2.0.3

[fvictorio]

Hi @payprmoney, thanks for reporting this. You are upgrading to version 2.0.4 of what? Hardhat? Or some plugin?

Also, is your repo public, or there's some way I can reproduce this?

[payprmoney]

The specific library we are updating is @nomiclabs/hardhat-ethers from 2.0.3 to 2.0.4.

The repo is ethereum-contracts and this is a PR that is failing.

[fvictorio]

Thank you! I'll take a look.

[fvictorio]

Hey @payprmoney, thanks a lot for reporting this. Definitely a bug on our side. We'll fix this and release a new version soon.

The underlying problem is that, when you run tsc, the Harhdat source is being compiled, and it's not compatible with your config. For the time being, there is a (lame) workaround you can do:

• Install @types/mocha
• Change your tsconfig.json to have noImplicitReturns: false

This assumes that you need the new methods added in hardhat-ethers v2.0.4. If not, then downgrading is perfectly fine.

[clemsos]

thanks @fvictorio . getting the same error here with 2.0.4, the fix works

Also this

node_modules/hardhat/src/types/runtime.ts:9:30 - error TS6133: 'T' is declared but its value is never read.

9 export interface ArgumentType<T> {

[fvictorio]

Yes, we fixed this but haven't released it yet. We'll do it early next week.

[alcuadrado]

This has already been released.