Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys help popup isn't easily scrollable #2332

Open
joelanman opened this issue Dec 22, 2022 · 4 comments
Open

Hotkeys help popup isn't easily scrollable #2332

joelanman opened this issue Dec 22, 2022 · 4 comments

Comments

@joelanman
Copy link

joelanman commented Dec 22, 2022

First, thanks, really enjoying using Pinafore!

If I press ? the Hotkeys popup appears. However on my screen at 1536x960 it's cropped. The last thing I can see is 'm to mention author'. If I zoom at all (a common accessibility tool) the cropping gets worse.

Tested in Safari on MacOS

Update Just realised it's scrollable! However I see no scrollbars at all, and the scrollable area is not visible, which is why I didn't realise. I did try scrolling before but I clearly wasn't in the scrollable area

@joelanman joelanman changed the title Hotkeys help popup is cropped at different screen sizes/zoom level Hotkeys help popup isn't easily scrollable Dec 22, 2022
@nolanlawson
Copy link
Owner

It depends on the OS and browser. Some show the scrollbar, some don't.

I don't think we should forcefully try to always show a scrollbar; we should follow the browser/OS defaults. Sorry it's not obvious in this case, but I can't think of a good solution.

Note that in your MacOS settings, there is a setting for making the scrollbar always visible across the entire OS. :)

@joelanman
Copy link
Author

joelanman commented Dec 28, 2022

Just a suggestion, but for me the issue was the scrollable area wasn't visible - here's what I mean:

hotkeys popup with a white border around the scrollable area

Obviously this could look nicer, but my point is I tried to scroll but because the scrollable area wasn't visible it didn't work. As there was no visible edge, I assumed the whole width was scrollable. It's true that macos hides scrollbars by default, but the area is normally delineated in some way

@nolanlawson
Copy link
Owner

I'll leave this open, even though I'm not sure how to solve it.

@nolanlawson nolanlawson reopened this Dec 28, 2022
@easrng
Copy link

easrng commented Jan 3, 2023

I don't think we should forcefully try to always show a scrollbar; we should follow the browser/OS defaults. Sorry it's not obvious in this case, but I can't think of a good solution.

As of right now the scrollbar is forcefully hidden with scrollbar-width: none;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants