Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of svgo is breaking the build 🚨 #1612

Closed
greenkeeper bot opened this issue Oct 29, 2019 · 6 comments
Closed

An in-range update of svgo is breaking the build 🚨 #1612

greenkeeper bot opened this issue Oct 29, 2019 · 6 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Oct 29, 2019

The dependency svgo was updated from 1.3.0 to 1.3.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

svgo is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for 1.3.1 / 29.10.2019
  • Updated CSSO version to 4.0.2 fixing the issue with empty semicolons ";;" in styles (thanks to @strarsis and @lahmatiy).
  • prefixIds plugin now runs only once with --multipass option (by @strarsis).
  • cleanupIDs plugin is prevented from producing a preserved ID, including one which matches a preserved prefix, when minifying (by @thomsj).
Commits

The new version differs by 6 commits.

  • 58232a3 v1.3.1
  • 0e6b0ad Fix 'cleanupIDs' minify bug due to preserved IDs
  • 71c7fe7 Add multipassCount to info object passed to the plugins.
  • 67be534 Update csso to 4.0.2 (+semicola in styles test) (#1172)
  • 11f9c79 Add active column in plugins table to readme
  • 9160a41 added node v12 in travis

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 29, 2019

After pinning to 1.3.0 your tests are passing again. Downgrade this dependency 📌.

@nolanlawson
Copy link
Owner

Seems like a real failure

@nolanlawson
Copy link
Owner

Seems related to svg/svgo#1177

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 30, 2019

  • The dependency svgo was updated from 1.3.1 to 1.3.2.

Your tests are passing again with this update. Explicitly upgrade to this version 🚀

Release Notes for 1.3.2 / 30.10.2019
  • Fixed TypeError: Cannot set property 'multipassCount' of undefined
Commits

The new version differs by 2 commits.

See the full diff

@nolanlawson
Copy link
Owner

fixed

@nolanlawson
Copy link
Owner

#1613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant