Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming Assert-Same to Assert-ReferenceEqual to avoid confusion #7

Open
nohwnd opened this issue Jul 31, 2017 · 1 comment
Open

Consider renaming Assert-Same to Assert-ReferenceEqual to avoid confusion #7

nohwnd opened this issue Jul 31, 2017 · 1 comment
Labels
feedback needed maybe

Comments

@nohwnd
Copy link
Owner

nohwnd commented Jul 31, 2017 •
edited

same is pretty well known to compare by reference in most testing framework, but the usability of reference comparison is low in powershell, and it's easy to mistake it for equality. Consider renaming the assertion to Assert-ReferenceEqual to make it less discoverable, and hence harder to use by accident.
@nohwnd
Copy link
Owner Author

nohwnd commented Nov 16, 2017

@alx9r Got any opinion on that?

@nohwnd nohwnd closed this as completed Nov 16, 2017
@nohwnd nohwnd reopened this Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback needed maybe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nohwnd