Launch timeout triggers during lazy download

[Jomshir98]

Versions

• NodeJS: v18.12.1
• mongodb-memory-server-core: 8.10.0
• system: Tested on multiple platforms (Win+Linux)

package: mongo-memory-server-core

What is the Problem?

When mongodb binary isn't already downloaded, the launch timeout triggers during the download process

Code Example

return await MongoMemoryServer.create({
	binary: {
		version: '5.0.6',
		checkMD5: false,
	},
	instance: {
		args: ['--setParameter', 'diagnosticDataCollectionEnabled=false'],
	},
});

Debug Output

Instance failed to start within 10000ms

Do you know why it happens?

Yes: Timeout created at

mongodb-memory-server/packages/mongodb-memory-server-core/src/util/MongoInstance.ts

Lines 348 to 374 in c4756c4

	const launch: Promise<void> = new Promise<void>((res, rej) => {
	this.once(MongoInstanceEvents.instanceReady, res);
	this.once(MongoInstanceEvents.instanceError, rej);
	this.once(MongoInstanceEvents.instanceClosed, function launchInstanceClosed() {
	rej(new Error('Instance Exited before being ready and without throwing an error!'));
	});
	// extra conditions just to be sure that the custom defined timeout is valid
	const timeoutTime =
	!!this.instanceOpts.launchTimeout && this.instanceOpts.launchTimeout >= 1000
	? this.instanceOpts.launchTimeout
	: 1000 * 10; // default 10 seconds
	timeout = setTimeout(() => {
	const err = new GenericMMSError(`Instance failed to start within ${timeoutTime}ms`);
	this.emit(MongoInstanceEvents.instanceError, err);
	rej(err);
	}, timeoutTime);
	}).finally(() => {
	// always clear the timeout after the promise somehow resolves
	clearTimeout(timeout);
	});
	const mongoBin = await MongoBinary.getPath(this.binaryOpts);
	await checkBinaryPermissions(mongoBin);
	this.debug('start: Starting Processes');

starts before call to await MongoBinary.getPath(this.binaryOpts); (which lazy-downloads the binary), meaning the timeout times out during slow download too.
Fix could be moving await MongoBinary.getPath(this.binaryOpts); before the timeout start.

[hasezoey]

thanks for reporting, didnt consider this - version should be published in ~10min as 8.10.1

[github-actions]

🎉 This issue has been resolved in version 8.10.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀