HTTP Host header standard ports

[karrots]

Expected behavior

HTTP module sends port as portion of Host header value only if using non-standard ports

Actual behavior

HTTP module sends host:port even when using standard ports. While technically not against RFC it does break some virtual host environments.

Link to another project that details this issue.

• Port 80 is included in the 'Host' request field (instead of defaulted) when it isn't with other popular HTTP clients request/request#515
• https://www.joedog.org/2014/09/05/is-a-port-number-required-in-the-http-host-header/

Test code

The code below when captured with Wireshark or similar packet capture will show Host: httpbin.org:80. Nginx or httpbin's code seems to strip the port 80 off the request before displaying it back to the user.

http.get("http://httpbin.org/headers", nil, function(code, data)
    if (code < 0) then
      print("HTTP request failed")
    else
      print(code, data)
    end
  end)

NodeMCU version

dev 500bbce

Hardware

Bug hardware agnostic.