Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improper handling of relative location header #1523

Merged
merged 2 commits into from Jul 4, 2022
Merged

fix: improper handling of relative location header #1523

merged 2 commits into from Jul 4, 2022

Conversation

mymindishazel
Copy link
Contributor

fixes #1521

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022 •
edited

Codecov Report

Merging #1523 (e40aec2) into main (57e2434) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1523   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          50       50           
  Lines        4608     4608           
=======================================
  Hits         4367     4367           
  Misses        241      241
Impacted Files Coverage Δ
lib/handler/redirect.js 94.93% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e2434...e40aec2. Read the comment docs.

pauliesnug
pauliesnug approved these changes Jul 4, 2022
View reviewed changes
Copy link

@pauliesnug pauliesnug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

mcollina
mcollina approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 42c43f2 into nodejs:main Jul 4, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
@metcoder95
fix: improper handling of relative location header (nodejs#1523)
989d2d1
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
@crysmags
fix: improper handling of relative location header (nodejs#1523)
dd3c1b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@pauliesnug pauliesnug pauliesnug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the redirect handler does not correctly honor relative paths in the location header
4 participants
@mymindishazel @codecov-commenter @mcollina @pauliesnug