Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add example with HEAD method to garbage collection section #1522

Merged
merged 1 commit into from Jul 2, 2022

Conversation

mrkldshv
Copy link
Contributor

@mrkldshv mrkldshv commented Jul 2, 2022

Adds example of getting headers using HEAD method to garbage collection section.

Closes #1505.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022

Codecov Report

Merging #1522 (6d4754e) into main (e53242d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          50       50           
  Lines        4608     4608           
=======================================
  Hits         4367     4367           
  Misses        241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53242d...6d4754e. Read the comment docs.

@mrkldshv mrkldshv force-pushed the feature/gc-docs-head-request branch from c2b1c21 to 6d4754e Compare July 2, 2022 11:38
@mrkldshv
Copy link
Contributor Author

mrkldshv commented Jul 2, 2022

@mcollina I guess it's failing because of the flaky tests on Windows. Can we restart CI?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 57e2434 into nodejs:main Jul 2, 2022
@mrkldshv mrkldshv deleted the feature/gc-docs-head-request branch July 2, 2022 15:51
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC example could be improved
3 participants