Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove git credentials after checkout #1477

Merged
merged 1 commit into from Jun 1, 2022
Merged

ci: remove git credentials after checkout #1477

merged 1 commit into from Jun 1, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Jun 1, 2022

See option description at https://github.com/actions/checkout#usage.
The repo does not use git in any run commands after checking out the repo in any of the workflow jobs.
This just removes the git credentials for security sake; should any used actions become compromised then at least they won't be exposed.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 87e586b into nodejs:main Jun 1, 2022
@Fdawgs Fdawgs deleted the ci/perms branch June 1, 2022 13:39
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants