Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip IPv6 tests if not supported #1476

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

LiviaMedeiros
Copy link
Contributor

This would unbreak testing in environments without IPv6 support.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1476 (db7a8cd) into main (4711982) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1476   +/-   ##
=======================================
  Coverage   94.70%   94.70%           
=======================================
  Files          49       49           
  Lines        4246     4246           
=======================================
  Hits         4021     4021           
  Misses        225      225           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711982...db7a8cd. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6843752 into nodejs:main Jun 1, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants