New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement FormData Iterator
#1473
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1473 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 49 49
Lines 4246 4249 +3
=======================================
+ Hits 4021 4024 +3
Misses 225 225
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's missing before this can be merged? |
A review from ronag I presume, who is currently on vacation 😄 |
pretty much |
Hmm, tried doing was using NodeJS 18.3.0 have a resent nodejs release been released with this fix? |
@jimmywarting v18.5.0 has |
Continuation of #1431 and #1423
Also adds in
FormData.forEach
which was added in the types but for some reason wasn't implemented.