Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support TypedArray and DataView as Request body #1472

Merged
merged 2 commits into from Jun 1, 2022

Conversation

LiviaMedeiros
Copy link
Contributor

  • ArrayBuffer.isView(BufferInstance) didn't allow isBuffer() branch to be reached
  • Fixed DataView dropping whole buffer into request body
  • Fixed the rest of ArrayBufferViews

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #1472 (c698a3f) into main (4711982) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
+ Coverage   94.70%   94.74%   +0.04%     
==========================================
  Files          49       49              
  Lines        4246     4246              
==========================================
+ Hits         4021     4023       +2     
+ Misses        225      223       -2     
Impacted Files Coverage Δ
lib/core/request.js 100.00% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4711982...c698a3f. Read the comment docs.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 48c03b6 into nodejs:main Jun 1, 2022
KhafraDev pushed a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
* fix: support `TypedArray` and `DataView` as Request body

* test: test `TypedArray` and `DataView` as Request body
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
* fix: support `TypedArray` and `DataView` as Request body

* test: test `TypedArray` and `DataView` as Request body
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
* fix: support `TypedArray` and `DataView` as Request body

* test: test `TypedArray` and `DataView` as Request body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants