Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test/fetch): <getter>.call will always throw #1438

Merged
merged 1 commit into from May 12, 2022

Conversation

KhafraDev
Copy link
Member

The tests would always pass regardless of if the assumption (accessing prototype methods/getters without a valid this value will throw) was correct.

For example,
File.prototype.name is a string, so .call(...) is not a function. It will always throw a TypeError, even if the brand check was removed.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #1438 (15582df) into main (1ae6d79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          49       49           
  Lines        4231     4231           
=======================================
  Hits         3993     3993           
  Misses        238      238           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae6d79...15582df. Read the comment docs.

@ronag ronag merged commit decc98c into nodejs:main May 12, 2022
@KhafraDev KhafraDev deleted the fix-test-getters branch May 12, 2022 16:44
KhafraDev added a commit to KhafraDev/undici that referenced this pull request Jun 23, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants