fix: import BodyReadable and Dispatcher correctly
#1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1424 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 49 49
Lines 4248 4248
=======================================
Hits 4005 4005
Misses 243 243 Continue to review full report at Codecov.
|
RA80533
changed the title
BodyReadable correctlyBodyReadable and Dispatcher correctly
| @@ -1,5 +1,5 @@ | |||
| import { expectAssignable } from 'tsd' | |||
| import BodyReadable from '../../types/readable' | |||
| import BodyReadable = require('../../types/readable') | |||
There was a problem hiding this comment.
is it possible for us to test both ways? I want to ensure we are not breaking allowSyntheticDefaultImports=true users
There was a problem hiding this comment.
It is! There is no impact for configurations with the setting enabled.
NMinhNguyen
reviewed
May 18, 2022
|
@Ethan-Arrowood could you review? |
|
Oh sorry I was waiting for another test case - but if it works still no worries |
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fix: import `BodyReadable` correctly * fix: import `Dispatcher` correctly * chore: fix `BodyReadable`'s import
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fix: import `BodyReadable` correctly * fix: import `Dispatcher` correctly * chore: fix `BodyReadable`'s import
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fix: import `BodyReadable` correctly * fix: import `Dispatcher` correctly * chore: fix `BodyReadable`'s import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of the changes made in #1059.
BodyReadableis imported with the assumption thatallowSyntheticDefaultImportsis enabled. This is restrictive to consumers wishing to use undici's type definitions without its enablement.The following imports have been fixed:
BodyReadablein test/types/readable.test-d.tsBodyReadablein types/dispatcher.d.tsDispatcherin types/mock-interceptor.d.ts