New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: premature end large body #805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, lgtm.
I think there's just some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a nit
if (request.method !== 'HEAD' && contentLength && bytesRead !== parseInt(contentLength, 10)) { | ||
util.destroy(socket, new ResponseContentLengthMismatchError()) | ||
return -1 | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this ignored by istanbul? Can't we reproduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think llhttp doesn't actually allow it, i.e. it shouldn't be possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have to dig into it further. Just to tired right now. Only slept 6 hours in total this week 😞 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take some rest 🙏🏻
* fix: premature end large body * fixup * fixup * fixup * fixuP * fixup * fixup * FIXUP * fixup * fixup * fixup * fixup
llhttp integer truncation on ARM platform.
Refs: #803
Refs: #429