New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "bench:simd" script fails with Missing script: "bench:run:simd" #795
Labels
bug
Something isn't working
Comments
The fix would depend on whether maintainers want to provide separate benchmark script with simd enabled. If benchmark includes simd enabled by default, then script diff --git a/package.json b/package.json
index b31c415..4d947c6 100644
--- a/package.json
+++ b/package.json
@@ -39,7 +39,6 @@
"coverage": "standard | snazzy && tap test/*.js",
"coverage:ci": "npm run coverage -- --coverage-report=lcovonly",
"bench": "concurrently -k -s first npm:bench:server npm:bench:run",
- "bench:simd": "concurrently -k -s first npm:bench:server npm:bench:run:simd",
"bench:server": "node benchmarks/server.js",
"prebench:run": "node benchmarks/wait.js",
"bench:run": "CONNECTIONS=1 node --experimental-wasm-simd benchmarks/benchmark.js && CONNECTIONS=50 node --experimental-wasm-simd benchmarks/benchmark.js", If an option to run benchmark with sim needs to be provided, then:
Shown in diff: diff --git a/package.json b/package.json
index b31c415..cb0fde4 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,8 @@
"bench:simd": "concurrently -k -s first npm:bench:server npm:bench:run:simd",
"bench:server": "node benchmarks/server.js",
"prebench:run": "node benchmarks/wait.js",
- "bench:run": "CONNECTIONS=1 node --experimental-wasm-simd benchmarks/benchmark.js && CONNECTIONS=50 node --experimental-wasm-simd benchmarks/benchmark.js",
+ "bench:run": "CONNECTIONS=1 node benchmarks/benchmark.js && CONNECTIONS=50 node benchmarks/benchmark.js",
+ "bench:run:simd": "CONNECTIONS=1 node --experimental-wasm-simd benchmarks/benchmark.js && CONNECTIONS=50 node --experimental-wasm-simd benchmarks/benchmark.js",
"serve:website": "docsify serve .",
"prepare": "husky install"
}, |
I'd like to keep the simd benchmark.. could you send a PR with that fix? |
PR adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
The "bench:simd" script fails with Missing script: "bench:run:simd"
Reproducible By
$ npm run bench:simd
Expected Behavior
The
bench:simd
script runs successfullyLogs & Screenshots
Environment
Additional context
N/A
The text was updated successfully, but these errors were encountered: