We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic authentication is hard coded at
undici/lib/proxy-agent.js
Line 59 in 8d6ddb7
Sometimes we have to use other authentication. (Bearer etc..)
Add additional parameter to options, which is type of authentication. Can I like to send a PR to fix this?
I think it is better to add an option because erasing the hard code is breaking changes.
The text was updated successfully, but these errors were encountered:
How about adding a new option like opts.token and set it directly to this[kProxyHeaders]['proxy-authorization']?
opts.token
this[kProxyHeaders]['proxy-authorization']
if (opts.token) { this[kProxyHeaders]['proxy-authorization'] = opts.token }
// user land const agent = new ProxyAgent({ uri: 'my.proxy.com', token: 'Bearer xxxx' })
Sorry, something went wrong.
PR welcome
Thanks for the answer! I have created a PR and would appreciate a review. #1705
No branches or pull requests
This would solve...
Basic authentication is hard coded at
undici/lib/proxy-agent.js
Line 59 in 8d6ddb7
Sometimes we have to use other authentication. (Bearer etc..)
The implementation should look like...
Add additional parameter to options, which is type of authentication.
Can I like to send a PR to fix this?
I have also considered...
I think it is better to add an option because erasing the hard code is breaking changes.
The text was updated successfully, but these errors were encountered: