Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't timeout while waiting for client to send request #1604

Merged
merged 2 commits into from Aug 17, 2022
Merged

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 17, 2022

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.
@ronag ronag requested a review from mcollina August 17, 2022 14:23
@ronag
Copy link
Member Author

ronag commented Aug 17, 2022

Note, fake-timers doesn't seem to work so well with refresh.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit affb7aa into main Aug 17, 2022
ronag added a commit that referenced this pull request Aug 17, 2022
* fix: don't timeout while waiting for client to send request

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.

* fixuP
ronag added a commit that referenced this pull request Aug 17, 2022
* fix: don't timeout while waiting for client to send request

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.

* fixuP
@dominykas dominykas mentioned this pull request Sep 13, 2022
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
)

* fix: don't timeout while waiting for client to send request

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.

* fixuP
@Uzlopak Uzlopak deleted the timeout branch February 21, 2024 12:37
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
)

* fix: don't timeout while waiting for client to send request

When e.g. uploading a large file from the client one would always
get a headers timeout even though everything was working and the file
was being in progress of sending.

* fixuP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants