fix: don't check socket writing on header timeout #1515
Merged
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengmk2
commented
Jun 25, 2022
| @@ -889,10 +889,8 @@ function onParserTimeout (parser) { | |||
|
|
|||
| /* istanbul ignore else */ | |||
| if (timeoutType === TIMEOUT_HEADERS) { | |||
| if (!socket[kWriting]) { | |||
There was a problem hiding this comment.
The server side does not consume and client socket is always writing state.
Codecov Report
@@ Coverage Diff @@
## main #1515 +/- ##
==========================================
+ Coverage 94.63% 94.66% +0.02%
==========================================
Files 50 50
Lines 4589 4589
==========================================
+ Hits 4343 4344 +1
+ Misses 246 245 -1
Continue to review full report at Codecov.
|
fengmk2
changed the title
fengmk2
force-pushed
the
fix-timeout-on-big-file-stream
branch
from
6c5abc1 to
76a2582
Compare
fengmk2
added a commit
to node-modules/urllib
that referenced
this pull request
Jun 25, 2022
fengmk2
added a commit
to node-modules/urllib
that referenced
this pull request
Jun 26, 2022
fengmk2
added a commit
to node-modules/urllib
that referenced
this pull request
Jul 5, 2022
fengmk2
added a commit
to node-modules/urllib
that referenced
this pull request
Jul 16, 2022
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.