Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursive filesystem operations api #78

Open
boneskull opened this issue Jul 10, 2020 · 1 comment
Open

recursive filesystem operations api #78

boneskull opened this issue Jul 10, 2020 · 1 comment

Comments

@boneskull
Copy link
Collaborator

We've got some feedback on the recursive rmdir API; see nodejs/node#34278

Given that the recursive option is still experimental, we can still break it, if necessary. Note that the recursive option for mkdir is not marked experimental.

This may be a good topic for a deep-dive session as noted by @bengl in #73. Also, input on API design from @nodejs/fs would be helpful.

Questions include, but are not limited to:

  • Do we want to add more granular options to fs.rmdir? e.g., allowRetries, force
  • Do we want to move the recursive functionality to a new method, or a new module entirely?
  • Should POSIX alignment be a goal for the fs module? Even if not, should we stay out of it anyway?
  • fs.rmdir w/ recursive actually functions like rm -f if given a file instead of a directory. Should it do that?

Note: It does not sound like outright removal of this functionality is being suggested anywhere.

It's pretty clear to me, anyway, that the current API is a product of various constraints, and not necessarily technical ones...

@wesleytodd
Copy link
Member

I commented in the meeting that much usage of these api's probably comes from a handful of fs wrapper libraries. To follow up on those, here are the most popular ones I know of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants