From b50a846305971de286fc2b34bf10f22f610f6bcd Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Thu, 26 Sep 2019 15:34:58 -0400 Subject: [PATCH 1/6] tests: add GitHub Actions CI --- .github/workflows/ci.yml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000000..2d86cbe051 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,19 @@ +name: GitHub Actions CI + +on: [push] + +jobs: + build: + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, windows-latest, macOS-latest] + node-version: [6.x, 8.x, 10.x, 12.x] + steps: + - uses: actions/checkout@v1 + - name: Use Node.js ${{ matrix.node-version }} on ${{ matrix.os }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + - name: npm run test + run: npm run test \ No newline at end of file From aa48f7f18dde2f8f3890b3e557f07c771440fd8f Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Thu, 26 Sep 2019 16:05:24 -0400 Subject: [PATCH 2/6] fix: add missing newline at the end of ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d86cbe051..f29c75759f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,4 +16,4 @@ jobs: with: node-version: ${{ matrix.node-version }} - name: npm run test - run: npm run test \ No newline at end of file + run: npm run test From 6d9e73c30db70af67a83996bb30e563a68e08933 Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Thu, 26 Sep 2019 16:07:47 -0400 Subject: [PATCH 3/6] fix: add `pull_request` trigger to GitHub Workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Michaƫl Zasso --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f29c75759f..682707de7d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,6 +1,6 @@ name: GitHub Actions CI -on: [push] +on: [push, pull_request] jobs: build: From b9756bb8c7bbf0abd8f98901425bc7a3c42c1693 Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Thu, 26 Sep 2019 16:42:52 -0400 Subject: [PATCH 4/6] fix: add missing `npm install` --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 682707de7d..24a4f674c5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -15,5 +15,7 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - - name: npm run test - run: npm run test + - name: npm install and npm run test + run: | + npm install + npm run test From c66aeeb15a347c9d05f195f18a19eaa053b20037 Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Fri, 25 Oct 2019 13:07:14 -0400 Subject: [PATCH 5/6] fix: add fail-fast: false to ci.yml Co-Authored-By: XhmikosR --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 24a4f674c5..a654ef998e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,6 +6,7 @@ jobs: build: runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macOS-latest] node-version: [6.x, 8.x, 10.x, 12.x] From ab4fb53ef74db808609d2ea1fdfc905a3f0b6ef1 Mon Sep 17 00:00:00 2001 From: Tierney Cyren Date: Fri, 25 Oct 2019 13:19:04 -0400 Subject: [PATCH 6/6] fix: Split npm install and npm run test in ci.yml --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a654ef998e..ea6fdaf16e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - - name: npm install and npm run test - run: | - npm install - npm run test + - name: npm install + run: npm install + - name: npm run test + run: npm run test