Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/test-replacements.js: fix typo. #415

Merged
merged 1 commit into from
Oct 24, 2019
Merged

build/test-replacements.js: fix typo. #415

merged 1 commit into from
Oct 24, 2019

Conversation

XhmikosR
Copy link
Contributor

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the test fix? Those are imported from Node core, so you should send that change there.

@vweevers
Copy link
Contributor

@mcollina I was just looking at that; the typo (and surrounding code) doesn't exist in node core.

It seems our tests are a bit outdated? https://github.com/nodejs/node/blob/master/test/parallel/test-stream2-unpipe-drain.js

@XhmikosR
Copy link
Contributor Author

I have already made upstream patches and trying to fix the typos across the whole ecosystem :)

nodejs/node#29075

@mcollina
Copy link
Member

mcollina commented Aug 10, 2019

@vweevers The tests are pulled from the Node 10.x release, as well as the rest of the code.

We might do a semver-major bump when Node 12 goes LTS.

@XhmikosR can you remove the test change from this PR?

@XhmikosR XhmikosR changed the title Assorted typo fixes. build/test-replacements.js: fix typo. Aug 10, 2019
@XhmikosR
Copy link
Contributor Author

@mcollina: done

@XhmikosR
Copy link
Contributor Author

@mcollina friendly ping

@mcollina mcollina merged commit edd8c2d into nodejs:master Oct 24, 2019
@mcollina
Copy link
Member

Thanks!

@XhmikosR XhmikosR deleted the master-xmr-typos branch October 25, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants