readable-browser.js does not export everything readable.js does

[angelo-v]

I am wondering, why readable-browser.js is missing some exports. E.g. readable.js is exporting finished and a library that I am using imports it. readable-browser.js does not export finished. Now my application breaks, because finished is undefined in a browser application.

Is this intentional? Am I using it wrong?

[angelo-v]

finished and pipeline got added to readable.js in this commit and it seams to me, that it just was forgotten to update readable-browser.js

[mcollina]

Good spot! Would you like to send a PR?

[angelo-v]

I could add those exports to readable-browser.js, yes. But what is the purpose to differ between readable-browser.js and readable.js in general? Is the separation still justified?

[mcollina]

readable.js accesses the process.env object. readable-browser.js does not, and it will yield smaller bundles.
Overall, yes, they are justified and needed.

[angelo-v]

Ok, I will prepare a PR

[angelo-v]

fixed via #409