Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build from Node v10.15.3 #402

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Build from Node v10.15.3 #402

merged 1 commit into from
Apr 1, 2019

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Mar 28, 2019 •
edited

Fixes #387

@mcollina
Copy link
Member Author

@vweevers can you take a look?

@vweevers
Copy link
Contributor

Short on time, maybe tomorrow, else next week

@mcollina
Copy link
Member Author

cc @lpinca?

@lpinca
Copy link
Member

lpinca commented Mar 28, 2019

I'm not familiar enough with this codebase to comment on or approve this PR, sorry Matteo.

vweevers
vweevers approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3ec079e into master Apr 1, 2019
@mcollina mcollina deleted the node-10.15.3 branch April 1, 2019 07:10
@snyk-bot snyk-bot mentioned this pull request Nov 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh mafintosh approved these changes

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcollina @vweevers @lpinca @mafintosh