Fix errors in IE11 #365
Closed
Fix errors in IE11 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiesey
commented
Sep 25, 2018
lib/_stream_readable.js
Outdated
| return value !== value; | ||
| } | ||
| } | ||
|
|
||
| // This function is designed to be inlinable, so please take care when making | ||
| // changes to the function body. |
There was a problem hiding this comment.
Right, I totally didn't read this comment. I'll fix this.
* Polyfill Number.isNaN * Don't create Symbol.asyncIterator if Symbol is not defined Fixes nodejs#364
|
I cleaned up the isNaN check; this version should be better |
|
@mafintosh @mcollina Is there anything else I need to do for this to get merged? |
Merged
|
Included in #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #364