Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node >= 6 to package.json #362

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Add node >= 6 to package.json #362

merged 1 commit into from
Sep 10, 2018

Conversation

dougwilson
Copy link
Member

Hi ! I noticed that in 3.x

v3.x.x of readable-stream supports Node 6, 8, and 10, ...

I added this to the package.json so automated tools that determine this requirement.

@mcollina
Copy link
Member

Thanks!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 4e54ee0 into nodejs:master Sep 10, 2018
@dougwilson
Copy link
Member Author

Thanks! But why did my email change in the commit? Can my private email be removed from master, please? I would like to use the email set on the commit in my PR if possible. Thanks!

@mcollina
Copy link
Member

I just hit the the "squash and merge button". You should probably remove your private email from Github. Which email do you want to use? I cannot easily see what you used in that commit.

@dougwilson
Copy link
Member Author

This is my commit: https://github.com/nodejs/readable-stream/commit/08f6c1162be23e0f2eb624a22cfe053241639f11.patch

I'm not sure what you mean by remove it from github. My somethingdoug.com email is on github.

@mcollina
Copy link
Member

I did not know what was your private email, and it was automatically used by Github when using the "squash" button. So, github knows your private email and tends to use it for these things. If you do not want it to appear in a commit, you should change your github configuration.

mcollina pushed a commit that referenced this pull request Sep 10, 2018
@dougwilson
Copy link
Member Author

Ah, I see. I will email github support and stop using github for the time being to see what is going on. Thanks for that info for what you did, I will pass that along!

Anyway, hopefully that patch link works for you. Otherwise it's just the email listed on my github profile that I want to use 👍

@mcollina
Copy link
Member

I've just amended the commit and force-pushed. Please check.

@dougwilson
Copy link
Member Author

Looks good. Sorry for the trouble of what should have been a simple PR 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants